GPU JetCore Cluster Splitter#8
Open
AdrianoDee wants to merge 9 commits intogpu_splitter_forPRfrom
Open
Conversation
Owner
Author
|
@stefanocolafranceschi (faccio una prova del tag) |
AdrianoDee
commented
Apr 2, 2025
Comment on lines
+24
to
+30
| void setNModules(uint32_t nModules) { nModules_h = nModules; } | ||
|
|
||
| uint32_t nModules() const { return nModules_h; } | ||
| uint32_t nDigis() const { return this->view().metadata().size() - 1; } | ||
|
|
||
| private: | ||
| uint32_t nModules_h = 0; |
Owner
Author
There was a problem hiding this comment.
Credo tutto questo si possa togliere.
There was a problem hiding this comment.
assolutamente scusa, era legacy (anche nel geoCluster)
Owner
Author
There was a problem hiding this comment.
E figurati, sto semplificando la CanidateSoA (Host,Device,Collection).
AdrianoDee
pushed a commit
that referenced
this pull request
May 12, 2025
Implement comments, cleaning, create bph namespace and remove fillDescriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this just as internal review.