Skip to content

Use design tokens for notification badge colors#136

Open
vku2018 wants to merge 1 commit into
Ads-Bazaar:mainfrom
vku2018:grantfox-58-notification-bell
Open

Use design tokens for notification badge colors#136
vku2018 wants to merge 1 commit into
Ads-Bazaar:mainfrom
vku2018:grantfox-58-notification-bell

Conversation

@vku2018

@vku2018 vku2018 commented Jul 3, 2026

Copy link
Copy Markdown

Summary

  • replace the notification badge's hardcoded inline hex/fallback colors with variant-specific design tokens
  • add landing-page danger/on-danger tokens alongside the existing landing token set
  • make the dashboard notification badge use the existing --dash-danger and --dash-on-danger token pair

This finishes the token-system acceptance item for the notification bell implementation currently on main.

Closes #58.

Validation

  • git diff --check passes
  • apps/frontend/node_modules/.bin/tsc.CMD --noEmit runs, but the repo currently fails on pre-existing unrelated errors:
    • app/dashboard/creator/campaigns/[id]/page.tsx: missing @/components/dashboard/creator/dashboard-header
    • app/dashboard/creator/campaigns/page.tsx: CampaignListRow receives unsupported onClick
  • next lint is not available as a Next 16 subcommand in this repo; direct ESLint currently fails during config loading with an existing circular config serialization error before reaching changed files

@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

@finiteskills is attempting to deploy a commit to the victorjames408gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add global notification bell with dropdown panel across Navbar and dashboards

2 participants