Skip to content

all unmeasured pixels treated as unconstrained#64

Merged
mdw771 merged 4 commits intomainfrom
leave_all_unmeasured_pixels_unconstrained
Mar 13, 2026
Merged

all unmeasured pixels treated as unconstrained#64
mdw771 merged 4 commits intomainfrom
leave_all_unmeasured_pixels_unconstrained

Conversation

@a4894z
Copy link
Copy Markdown
Collaborator

@a4894z a4894z commented Mar 11, 2026

currently we use a fixed unmeasured pixel binary mask to define regions where we do not enforce the measurement constraint. this fix allows us to treat all unmeasured pixels as unconstrained.

this was an issue for us for recent beamtime where some measurements had saturated low Q pixels, and by enforcing these saturated pixels, the reconstruction would have crappy artifacts.

we tried to zero these pixels out, and enforced those zeroed out low Q regions, but this would cause another set of crappy artifacts.

simply leaving all unmeasured pixels unconstrained when performing exitwave updates solved this problem for us, and here's the code I used to make this happen.

where we do not enforce the measurement constraint. this fix allows us
to treat all unmeasured pixels as unconsstrained
@a4894z a4894z requested review from mdw771 and stevehenke March 11, 2026 23:07
mdw771 added 2 commits March 13, 2026 12:01
…ake it a threshold, move it to `ReconstructorOptions`, and remove unnecessary plumbing
@mdw771
Copy link
Copy Markdown
Collaborator

mdw771 commented Mar 13, 2026

  • Renamed the option to exclude_measured_pixels_below: it sets the gradients of pixels corresponding to measurements <= the set value to 0.
  • The option is now in ReconstructorOptions.
  • Extended valid pixel mask and this dynamic thresholding mask to all reconstructor, not just LSQML.

@mdw771 mdw771 merged commit e7e10de into main Mar 13, 2026
2 checks passed
@a4894z a4894z deleted the leave_all_unmeasured_pixels_unconstrained branch March 17, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants