Skip to content

v6 - Add compose previews to text fields#2680

Merged
jreij merged 10 commits intomainfrom
chore/text-field-previews
Apr 9, 2026
Merged

v6 - Add compose previews to text fields#2680
jreij merged 10 commits intomainfrom
chore/text-field-previews

Conversation

@jreij
Copy link
Copy Markdown
Collaborator

@jreij jreij commented Apr 3, 2026

Description

Add compose previews to all existing text fields.

Checklist

  • Changes are tested manually

Ticket Number

COSDK-921

@jreij jreij requested a review from a team as a code owner April 3, 2026 13:33
@AdyenAutomationBot AdyenAutomationBot added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Compose-based previews for various UI components, including BlikCodeField, CardNumberField, ExpiryDateField, HolderNameField, KCPBirthDateOrTaxNumberField, KCPCardPasswordField, SecurityCodeField, and SocialSecurityNumberField. It also updates the visibility of certain utility classes and functions to library group scope. Regarding the MBWayPhoneNumberField, the reviewer suggested renaming the 'countryCode' parameter to 'callingCode' to better reflect that it represents a phone calling code rather than an ISO country code, which improves clarity and consistency.

Comment thread card/src/main/java/com/adyen/checkout/card/internal/ui/view/CardNumberField.kt Outdated
@jreij jreij force-pushed the chore/text-field-previews branch from f29201a to edf51df Compare April 9, 2026 08:42
@jreij jreij force-pushed the chore/text-field-previews branch from edf51df to 6ee6cfa Compare April 9, 2026 08:43
@jreij jreij enabled auto-merge April 9, 2026 08:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

✅ No public API changes

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@jreij jreij added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit e176ece Apr 9, 2026
10 of 11 checks passed
@jreij jreij deleted the chore/text-field-previews branch April 9, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes size:large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants