Conversation
…SDK data fields COSDK-1148
There was a problem hiding this comment.
Code Review
This pull request introduces the PaymentMethodBehavior enum and updates the SdkData model to include mandatory fields for SDK version, platform, channel, and payment method behavior. These changes are propagated through the SdkDataProvider interface and its implementations, ensuring that analytics and component behavior are correctly tracked and handled. The review feedback focuses on improving the SdkData class by reordering constructor parameters to follow Kotlin best practices (mandatory before optional), aligning serialization logic with this new order, and renaming constants to better match their corresponding JSON keys for consistency.
COSDK-1148
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'PaymentMethodBehavior' enum to distinguish between generic and native component support, updating 'SdkData' and 'DefaultSdkDataProvider' to include this behavior along with SDK version, platform, and channel information. The reviewer suggests restoring default values for optional fields in the 'SdkData' constructor to maintain a cleaner API, recommending that the new mandatory fields be placed before the optional ones.
✅ No public API changes |
|
There was a problem hiding this comment.
PR should not be merged until fully tested end to end



Description
Add 4 new fields to
sdkData:channel/platform/sdkVersion/paymentMethodBehavior.Checklist
Ticket Number
COSDK-1148
Release notes
Changed
onSubmitcallback has increased in size, because of changes to the includedsdkDatafield.