v6 - Architecture - Remove ViewModel concept#2685
Merged
OscarSpruit merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
OscarSpruit
added
the
Chore
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the MBWayProvider class and its associated infrastructure, including the interface and registration logic in PaymentMethodProvider. The MBWayInitializer has been updated to remove the registration of the provider. I have identified an unused import in MBWayInitializer.kt that should be removed to maintain code cleanliness.
Base automatically changed from
chore/v6-architecture-compojnent-in-controller
to
main
April 8, 2026 14:20
In this concept every payment method composable created it's own ViewModel. We decided to go with a different approach. COSDK-1115
OscarSpruit
force-pushed
the
chore/v6-architecture-remove-view-model-concept
branch
from
28cc591 to
ce2b90d
Compare
Contributor
✅ No public API changes |
|
araratthehero
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this concept every payment method composable created it's own ViewModel. We decided to go with a different approach.
Ticket Number
COSDK-1115