[balanceplatform] Code generation: update services and models

[AdyenAutomationBot]

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

[gemini-code-assist]

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the update of services and models for the balanceplatform service, incorporating new API functionalities generated from the adyen-openapi specification. It ensures the client library remains synchronized with the latest API definitions.

Highlights

• New API Endpoint: Added the get_tax_form_summary method to the AccountHoldersApi service, enabling the retrieval of tax form summaries for specific account holders.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• lib/adyen/services/balancePlatform/account_holders_api.rb
  • Added the get_tax_form_summary method to fetch tax form summaries for account holders.

Activity

• Automated code generation process initiated by AdyenAutomationBot.
• Updated services and models based on the latest adyen-openapi specification.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new get_tax_form_summary method to the AccountHoldersApi, which appears to be an automated, generated change. The implementation is consistent with other methods in the file. My review includes a couple of suggestions to enhance code quality by addressing code duplication in endpoint construction and refining how query strings are generated. These improvements could be beneficial if applied more broadly, perhaps even to the code generator itself.

[gemini-code-assist]

This pattern for building the endpoint URL is duplicated across several methods in this class (e.g., get_account_holder, get_tax_form). To improve maintainability and reduce redundancy, consider extracting this logic into a private helper method.

For example:

private

def build_endpoint(path, *params)
  endpoint = path.gsub(/{.+?}/, '%s').delete_prefix('/')
  format(endpoint, *params)
end

This would allow you to simplify the implementation in this and other methods:

def get_tax_form_summary(id, headers: {}, query_params: {})
  endpoint = build_endpoint('/accountHolders/{id}/taxFormSummary', id)
  # ...
end

[gemini-code-assist]

The create_query_string method appends a ? to the URL even when query_params is empty. While this is generally not a functional issue, it results in URLs with a trailing ? when no query parameters are provided. It would be cleaner to modify create_query_string to only append the query string when parameters are present.

Suggested change in lib/adyen/services/service.rb:

def create_query_string(params)
  return '' if params.empty?
  "?#{URI.encode_www_form(params)}"
end

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud