Skip to content

Remove debugging puts#353

Merged
gcatanese merged 1 commit intoAdyen:mainfrom
therubyhound:remove-debugging-puts
Mar 9, 2026
Merged

Remove debugging puts#353
gcatanese merged 1 commit intoAdyen:mainfrom
therubyhound:remove-debugging-puts

Conversation

@therubyhound
Copy link
Contributor

Description
This PR removes a puts statement that I assume was only used for debugging.
It causes noise in test output of our application that that includes this Gem as a dependency.

Tested scenarios
N/A

@therubyhound therubyhound requested review from a team as code owners March 3, 2026 15:26
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code cleanliness and developer experience by removing a debugging puts statement. This change prevents unnecessary console output during test runs, leading to clearer and less cluttered test results for consumers of the Gem.

Highlights

  • Debugging Output: Removed a puts statement that was previously used for debugging within the HMACValidator.
  • Test Clarity: Eliminated noisy output during testing for applications that depend on this Gem.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • lib/adyen/utils/hmac_validator.rb
    • Removed a debugging puts statement from the valid_webhook_payload_hmac? method.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a debugging puts statement from the valid_webhook_payload_hmac? method in lib/adyen/utils/hmac_validator.rb. This is a correct and beneficial change as it eliminates unnecessary output which, as noted in the description, was causing noise in test environments. The change is approved as is.

@therubyhound therubyhound force-pushed the remove-debugging-puts branch from 71a5912 to f7b934c Compare March 3, 2026 17:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

@gcatanese gcatanese added the Fix label Mar 9, 2026
@gcatanese
Copy link
Contributor

Thank you @therubyhound for your contribution!

@gcatanese gcatanese added this pull request to the merge queue Mar 9, 2026
Merged via the queue into Adyen:main with commit 4a9e3e2 Mar 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants