[capital] Code generation: update services and models#354
[capital] Code generation: update services and models#354AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Adyen Ruby client for the Capital service. It expands the API capabilities by adding a new service for managing dynamic offers and refines the terminology for existing grant offers, now referred to as static offers. This ensures the client library remains synchronized with the latest API specifications, providing developers with updated and clearer access to Capital service functionalities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new DynamicOffersApi service, integrating it into the Capital service, and clarifies comments in GrantOffersApi. However, it introduces potential path injection vulnerabilities in the calculate_preliminary_offer_from_dynamic_offer and create_static_offer_from_dynamic_offer methods, where the id parameter is used in the URL path without proper encoding. This could allow path traversal if the id is from untrusted input. Additionally, there's an opportunity to simplify string manipulation in the get_all_dynamic_offers method.
| def calculate_preliminary_offer_from_dynamic_offer(request, id, headers: {}) | ||
| endpoint = '/dynamicOffers/{id}/calculate'.gsub(/{.+?}/, '%s') | ||
| endpoint = endpoint.gsub(%r{^/}, '') | ||
| endpoint = format(endpoint, id) |
There was a problem hiding this comment.
The id parameter is directly formatted into the endpoint string without any URL encoding or validation. If an attacker can control the id value, they could potentially perform path traversal (e.g., using ../) to access other endpoints on the Adyen API host. It is recommended to URL encode the id parameter before formatting it into the endpoint string using URI.encode_www_form_component(id).
| def create_static_offer_from_dynamic_offer(request, id, headers: {}) | ||
| endpoint = '/dynamicOffers/{id}/grantOffer'.gsub(/{.+?}/, '%s') | ||
| endpoint = endpoint.gsub(%r{^/}, '') | ||
| endpoint = format(endpoint, id) |
There was a problem hiding this comment.
The id parameter is directly formatted into the endpoint string without any URL encoding or validation. If an attacker can control the id value, they could potentially perform path traversal (e.g., using ../) to access other endpoints on the Adyen API host. It is recommended to URL encode the id parameter before formatting it into the endpoint string using URI.encode_www_form_component(id).
| endpoint = '/dynamicOffers'.gsub(/{.+?}/, '%s') | ||
| endpoint = endpoint.gsub(%r{^/}, '') | ||
| endpoint = format(endpoint) |
There was a problem hiding this comment.
The gsub and format calls on these lines are redundant for the /dynamicOffers endpoint as it does not contain any path parameters that need to be replaced. Simplifying this will make the code cleaner and more efficient.
endpoint = 'dynamicOffers'
endpoint += create_query_string(query_params)1 participant
This PR contains the automated changes for the
capitalservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.