Fix: enforce argument validation in Client#initialize via setter methods

[Copilot]

Client.new(env: "live") silently accepted invalid env values by assigning directly to @env, bypassing the env= setter's ArgumentError guard. Same issue applied to live_url_prefix.

Changes

• initialize: Use self.env = env and self.live_url_prefix = live_url_prefix instead of direct instance variable assignment, so setter validations apply at construction time
• live_url_prefix=: Guard against nil input (needed since nil is the default, and the setter previously called [] on the value unconditionally)

Before / After

# Before: silently accepted, causing subtle bugs downstream (e.g. `@env == :live` checks)
client = Adyen::Client.new(env: "live")  # no error raised

# After: consistent with setter behaviour
client = Adyen::Client.new(env: "live")  # => ArgumentError
client.env = "live"                       # => ArgumentError (already worked)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Bug]: Client is initialized without proper argument check</issue_title>
<issue_description>### Description

Initializing client skips argument checks and validations

Steps to reproduce

Call Adyen::Client.new with arguments env or live_url_prefix instead of using the env=, live_url_prefix= methods.

This allows initializing client with invalid env, which has implications later in code, e.g. checks like this(@env == :live)

Actual behavior

# This correctly raises ArgumentError, because we set "live" instead of (symbol) :live
client = Adyen::Client.new
client.env = "live"

# This should also raise ArgumentError, but doesn't:
client = Adyen::Client.new(env: "live")

(Similar case can be made for live_url_prefix.)

Expected behavior

# This should also raise ArgumentError
client = Adyen::Client.new(env: "live")

Code snippet or screenshots (if applicable)

Proposal solution: use the setter methods also in initialize.

# in client.rb
def initialize(...)
  ...
  @env = env # <-- replace with `self.env = env`
  ...
  @live_url_prefix = live_url_prefix # <-- replace with self.live_url_prefix = live_url_prefix
  ...  
end

Adyen Ruby API Library version

10.2.0

Ruby language version

3.4.1

Operating System

macOS

Additional context

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [Bug]: Client is initialized without proper argument check #355

---

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud