BUG-19-streak-calculation-problem#20
Open
Zahlkovsk1 wants to merge 5 commits intoSM-004-Streakfrom
Open
Conversation
…ting variable that replaces timeSpent, so now the streak Calculation is working as expected
g-cqd
requested changes
Mar 17, 2025
Member
g-cqd
left a comment
g-cqd
left a comment
There was a problem hiding this comment.
Please remove timeSpent is the variable is unused.
Can you create a view model for the StreakView and add some tests to validate the calculation please?
| } else if tab.id == .streakGoal { | ||
| VStack { | ||
| StreakView(timeSpent: timeSpent ?? 0.0) | ||
| StreakView(sessions: sessions, timeSpent: timeSpent ?? 0.0) |
Member
There was a problem hiding this comment.
if timeSpent is not used, why keeping it?
added 4 commits
March 20, 2025 11:10
…meSpent var from the StreakView, introduced the viewModel, moved the half of the logic to the viewModel
…rted computedTime to a function
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreakView was updated, added existing variable that replaces timeSpent, so now the streak Calculation is working as expected