Bump rustc to nightly-2026-05-31#1226
Open
N1ark wants to merge 2 commits into
Open
Conversation
N1ark
force-pushed
the
update-rustc-again
branch
5 times, most recently
from
85179c4 to
a02b36c
Compare
Nadrieril
reviewed
Jun 1, 2026
Comment on lines
-1040
to
+1051
| return Ok(Rvalue::Use(Operand::Copy( | ||
| p.project(ProjectionElem::PtrMetadata, tgt_ty.clone()), | ||
| ))); | ||
| return Ok(Rvalue::Use( | ||
| Operand::Copy( | ||
| p.project(ProjectionElem::PtrMetadata, tgt_ty.clone()), | ||
| ), | ||
| WithRetag::No, | ||
| )); |
Member
There was a problem hiding this comment.
Why not a retag here? The only non-retagging copy is CopyForDeref, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump rustc again! Our current toolchain is causing me problems in Obol so i'd like to move on from it quickly 🫠
Relevant PRs:
Unnormalized<_>: i tried adding the right calls here and there, but feel free to comment on places where i shouldn't skip normalization etc. Hopefully this improves as rustc's adoption ofUnnormalizedimproves.Unnormalized migration: assert_fully_normalized, struct_tail, and
field.tyrust-lang/rust#156224Rvalue::Reborrow: for now we don't translate itExperiment: Reborrow traits rust-lang/rust#151753
Rvalue::Use(_, WithRetag): added it, and added it in the transformations. I tried to be liberal and useWithRetag::Noby default, to avoid introducing UBMake retags an implicit part of typed copies rust-lang/rust#154341