Fix uniform sample weight knot placement#15
Merged
Conversation
5ee5608 to
fe2636c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes weighted knot placement so uniform nonzero
sample_weightvalues preserve the same interpolated quantiles as the unweighted path.Root Cause
The weighted quantile path used a step-CDF lookup for all weighted calls. Passing
sample_weight=np.ones(n)therefore changed knot placement relative tosample_weight=None, which could change the spline basis and fitted predictions for a semantic no-op.Changes
_weighted_quantileweight shape directly.np.quantilefor uniform nonzero weights to preserve NumPy interpolation.Validation
PYTHONPATH=src pytest->133 passed, 1 xfailed