Ios crash issue 87#98
Open
Wahab-Khan wants to merge 2 commits into
Open
Conversation
Avoid force-unwrapping window/rootViewController by supporting both UIScene (iOS 13+) and legacy AppDelegate window lookup, and validate method call arguments to return FlutterError instead of crashing. Co-authored-by: Cursor <cursoragent@cursor.com>
Allow Dart <4.0.0 so the package can be used with modern Flutter/Dart toolchains. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window/rootViewControllerby supporting both UIScene (iOS 13+) and legacy AppDelegate window lookup.FlutterErrorinstead of crashing.<4.0.0).Context
Addresses crash reported in upstream issue #87.
Test plan
convertFromHtmlContenton an iOS 13+ scene-based app and confirm it no longer crashes.