Conversation
Arthur-Aillet
approved these changes
Mar 8, 2025
Contributor
Arthur-Aillet
left a comment
Arthur-Aillet
left a comment
There was a problem hiding this comment.
@syborg64 I have to trust you on this one, I read everything and didn't find a problem but don't count on me too much regarding rendering
Contributor
Author
|
given the significant changes in PRs that will be merged before this one, I expect that I'll have to fix some merge conflicts |
… use by-reference params internally
…ogic (BREAKING forward rendering)
3 tasks
Contributor
Author
|
waiting on #20 to merge first |
| @@ -0,0 +1,158 @@ | |||
| /* | |||
| ** Agartha-Software, 2023 | |||
| endif() | ||
| if (UNIX) | ||
| # target_link_libraries(assets PRIVATE GLEW::glew glfw glm::glm OpenGL::GL) | ||
| target_link_libraries(assets PRIVATE GLEW::glew glfw glm::glm OpenGL::GL) |
Contributor
There was a problem hiding this comment.
Why is glm public only on windows
| } | ||
| // static DEBUG flag - if set to false then, errors aside, we'll run completely silent | ||
| #ifndef DEBUG | ||
| static const bool DEBUG = true; |
Contributor
There was a problem hiding this comment.
There should be a DEBUG = false when !DEBUG?
| @@ -1,16 +1,24 @@ | |||
| // clang-format off | |||
| #define STBI_MALLOC(sz) ((void *)(new char[sz])) | ||
| #define STBI_REALLOC_SIZED(p, oldsz, newsz) \ | ||
| (size_t(newsz) <= size_t(oldsz) ? (void *)(p) \ | ||
| : [](void *lp, size_t loldsz, size_t lnewsz) -> void * { \ |
Contributor
There was a problem hiding this comment.
Set clearer variable names
| pipeline::Light gl_light = o_point.has_value() ? pipeline::Light(o_point.value(), tm) : // | ||
| (o_spot.has_value() ? pipeline::Light(o_spot.value(), tm) : // | ||
| (o_sun.has_value() ? pipeline::Light(o_sun.value(), tm) : // | ||
| throw std::runtime_error(""))); |
Contributor
There was a problem hiding this comment.
complete the runtime error content
| uint16_t shadow_viewlayer_bits; | ||
| }; | ||
|
|
||
| class SunLight { |
Contributor
There was a problem hiding this comment.
Move to other SunLight file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support normal-tangeant mapping
support obj pbr material loading
support user-defined materials and shaders
support multiple light types
support shadows for directional lights
restore functionality of Forward Renderer