Fix tracker: hasOwnProperty guard, hash idiom, deprecated substr#2
Merged
dannyshmueli merged 1 commit intomainfrom Feb 21, 2026
Merged
Fix tracker: hasOwnProperty guard, hash idiom, deprecated substr#2dannyshmueli merged 1 commit intomainfrom
dannyshmueli merged 1 commit intomainfrom
Conversation
- Add hasOwnProperty checks to for..in loops in baseProps() to prevent picking up extended Object.prototype properties from third-party scripts - Replace non-standard `hash & hash` with idiomatic `hash |= 0` for 32-bit integer coercion in experiment bucketing - Replace deprecated substr(2, 9) with slice(2, 11) in ID generation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasOwnPropertychecks tofor..inloops inbaseProps()to prevent picking up extendedObject.prototypeproperties from third-party scripts on host pageshash & hashwith idiomatichash |= 0for 32-bit integer coercion in experiment bucketingsubstr(2, 9)withslice(2, 11)in anon/session ID generationTest plan
npm test)npm run build)🤖 Generated with Claude Code