Skip to content

Fix Go review reliability and provider handling#58

Open
AbirAbbas wants to merge 4 commits into
mainfrom
6009eca6-integration
Open

Fix Go review reliability and provider handling#58
AbirAbbas wants to merge 4 commits into
mainfrom
6009eca6-integration

Conversation

@AbirAbbas

@AbirAbbas AbirAbbas commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix four production bugs in the Go port that could launch the wrong harness, reject coverage reviews, publish false green reviews, or lose review results during transient GitHub failures.

Changes

  • Fix provider-aware harness binary selection, with optional PR_AF_HARNESS_BIN override. This prevents Codex from accidentally executing the Opencode binary and crashing.
  • Make all registered reasoner array schemas OpenAI strict-mode valid by declaring items types. This prevents coverage-gate requests from failing with invalid_json_schema.
  • Propagate review-dimension failures so an all-dimensions crash fails without posting to GitHub, while partial failures proceed with degraded-dimension metadata. This prevents false green Looks Good reviews.
  • Retry review creation up to three times for transient 5xx/network failures with exponential backoff, without retrying 4xx errors. This prevents computed reviews from being dropped after GitHub timeouts.

Test plan

  • Run gofmt across the Go module.
  • Run go test ./... in go/.
  • Added unit coverage for provider mapping, strict schema arrays, all/partial/zero dimension failures, and 5xx/4xx review-post behavior.

@AbirAbbas
AbirAbbas force-pushed the 6009eca6-integration branch 2 times, most recently from 7f7a79c to 5bdf715 Compare July 24, 2026 18:46
@AbirAbbas
AbirAbbas force-pushed the 6009eca6-integration branch 2 times, most recently from 5bdf715 to ec84bf6 Compare July 24, 2026 19:00
@AbirAbbas AbirAbbas changed the title fix(go): deliver provider, schema, review, and GitHub reliability fixes Fix Go review reliability and provider handling Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant