[codex] Honor runtime bulkMaxItems config#219
Open
pq198363-ops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bulkMaxItemsconfig to both usage and service bulk endpoints.bulkMaxItemsso config changes cannot create unbounded in-memory batches.Closes #90
RED / GREEN evidence
bulk-limittests failed because usage bulk still accepted 3 items after loweringbulkMaxItemsto 2, services bulk still rejected 51 items after raising the limit to 60, and config acceptedbulkMaxItems: 1001.dist/bulk-limit.test.jstest passed.Verification
npx prettier --check README.md src/store/state.ts src/routes/config.ts src/routes/usage.ts src/routes/services.ts src/bulk-limit.test.ts src/services.test.tsnpm run lintnpm run build$env:NODE_ENV='test'; node --test dist/*.test.js dist/**/*.test.js(92 tests, 11 suites, 92 pass, 0 fail)git diff --check