[codex] Honor live rate limit config#221
Open
pq198363-ops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry-Afterand the rate-limit message from the activerateLimitWindowMsvalue./api/v1/configupdatesrateLimitPerWindowandrateLimitWindowMswithout a restart.Closes #36
Root cause
The config API accepted runtime updates to
rateLimitPerWindowandrateLimitWindowMs, but the rate limiter still imported frozen default constants. PATCHing/api/v1/configtherefore appeared successful while request limiting kept using the original 60 requests / 60s behavior.Verification
npm run build$env:NODE_ENV='test'; node --test dist/ratelimit-config.test.js(3 tests)npx prettier --check README.md src/store/state.ts src/middleware/index.ts src/ratelimit-config.test.tsnpm run lintdist, thennpm run build$env:NODE_ENV='test'; node --test dist/*.test.js dist/**/*.test.js(92 tests)git diff --checkNote:
npm testuses POSIX-styleNODE_ENV=test, so the verification above uses the Windows PowerShell-compatible form.