[codex] Clamp numeric query parameters#225
Open
pq198363-ops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91
Summary
parseIntParamhelper for defensive numeric query parsing.limitandsincehandling on the affected list endpoints:GET /api/v1/eventsGET /api/v1/agentsGET /api/v1/servicesGET /api/v1/services/:serviceId/agents/topValidation
RED evidence:
src/queryParams.tsdid not exist yet.GREEN evidence:
npx prettier --check README.md src/queryParams.ts src/query-params.test.ts src/routes/events.ts src/routes/services.ts src/routes/usage.tsnpm run lintgit diff --checkdist/, then rannpm run build$env:NODE_ENV='test'; node --test dist/*.test.js dist/**/*.test.jsResult: full test run passed, 93 tests across 11 suites.
Notes
Malformed, empty,
NaN, or infinite numeric query values now fall back to the endpoint default. Out-of-range finite values are clamped so bad input cannot propagateNaNinto slices or timestamp filters.