[codex] Validate agent and service identifiers#229
Open
pq198363-ops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Summary
agentandserviceId..,_, and-, preserving the existing 256-char agent and 128-char service caps.::, whitespace, newlines, commas, and control characters.Validation
RED evidence:
npm run buildsucceeded, then$env:NODE_ENV='test'; node --test dist/identifiers.test.jsfailed because unsafe identifiers such asbad::agentand newline-containing service IDs were accepted.GREEN evidence:
npm run build$env:NODE_ENV='test'; node --test dist/identifiers.test.jsnpx prettier --check README.md src/identifiers.ts src/identifiers.test.ts src/routes/usage.ts src/routes/services.tsnpm run lintgit diff --checkdist/, then rannpm run build$env:NODE_ENV='test'; node --test dist/*.test.js dist/**/*.test.jsResult: full clean test run passed, 93 tests across 11 suites.
Notes
The validation is intentionally ASCII-only and separator-safe because these IDs flow into
${agent}::${serviceId}keys, path params, events, and exports. Existing valid IDs using alphanumerics, dot, underscore, or hyphen continue to work.