Skip to content

test: cover error handler responses#242

Open
pq198363-ops wants to merge 1 commit into
Agentpay-Org:mainfrom
pq198363-ops:bounty-47-error-handler-tests
Open

test: cover error handler responses#242
pq198363-ops wants to merge 1 commit into
Agentpay-Org:mainfrom
pq198363-ops:bounty-47-error-handler-tests

Conversation

@pq198363-ops

Copy link
Copy Markdown

Summary

  • add dedicated src/errors.test.ts coverage for oversized JSON bodies, malformed JSON bodies, and unknown route fallbacks
  • assert every covered error response includes error, message, and requestId, without stack/internal path leakage
  • move request id attachment before express.json() so parser-generated 413 and malformed JSON errors can include the same request correlation field

RED evidence

Before the middleware-order fix, the focused suite failed because both parser-generated errors omitted requestId:

  • 413 payload_too_large for oversized JSON bodies
  • 500 internal_error for malformed JSON bodies

Verification

  • npx prettier --check src/errors.test.ts src/middleware/index.ts
  • npm run lint
  • git diff --check
  • $env:NODE_ENV='test'; node --test dist/errors.test.js
  • $env:NODE_ENV='test'; node --test dist/health.test.js dist/routes/operational.test.js
  • clean dist/, npm run build, $env:NODE_ENV='test'; node --test dist/*.test.js dist/**/*.test.js

Full clean test output summary:

  • tests: 93
  • suites: 11
  • pass: 93
  • fail: 0

Closes #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test coverage for the global error handler, 413 payload limit, and 404 fallback

1 participant