test: cover error handler responses#242
Open
pq198363-ops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/errors.test.tscoverage for oversized JSON bodies, malformed JSON bodies, and unknown route fallbackserror,message, andrequestId, without stack/internal path leakageexpress.json()so parser-generated 413 and malformed JSON errors can include the same request correlation fieldRED evidence
Before the middleware-order fix, the focused suite failed because both parser-generated errors omitted
requestId:413 payload_too_largefor oversized JSON bodies500 internal_errorfor malformed JSON bodiesVerification
npx prettier --check src/errors.test.ts src/middleware/index.tsnpm run lintgit diff --check$env:NODE_ENV='test'; node --test dist/errors.test.js$env:NODE_ENV='test'; node --test dist/health.test.js dist/routes/operational.test.jsdist/,npm run build,$env:NODE_ENV='test'; node --test dist/*.test.js dist/**/*.test.jsFull clean test output summary:
Closes #47