Detect batch#128
Merged
Merged
Conversation
…them with the originals (generates a new one, with to-be-replaced as attr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Type of Change
🧪 Improvement: Enhancements or optimizations to existing code
📝 Description
General improvements in detect step. We only add components when we're certain it's an accurate estimator. We grab multiple patches in a single cycle and merge them together if they overlap / trace-correlated. These are then merged with the existing components with the same conditions.
when merged with existing components, the replacer gets a new ID and the existing component is deleted. this is done through attr of xarray.
🧪 Testing
🛠️ Dependencies
✅ Checklist
📚 Documentation preview 📚: https://cala--128.org.readthedocs.build/en/128/