Skip to content

Detect batch#128

Merged
raymondwjang merged 15 commits into
mainfrom
detect-batch
Aug 14, 2025
Merged

Detect batch#128
raymondwjang merged 15 commits into
mainfrom
detect-batch

Conversation

@raymondwjang
Copy link
Copy Markdown
Member

@raymondwjang raymondwjang commented Aug 14, 2025

🔍 Type of Change

🧪 Improvement: Enhancements or optimizations to existing code

📝 Description

General improvements in detect step. We only add components when we're certain it's an accurate estimator. We grab multiple patches in a single cycle and merge them together if they overlap / trace-correlated. These are then merged with the existing components with the same conditions.

when merged with existing components, the replacer gets a new ID and the existing component is deleted. this is done through attr of xarray.

🧪 Testing

  • Ran unit tests
  • Ran integration tests
  • Performed manual testing
  • Updated existing tests

🛠️ Dependencies

✅ Checklist

  • My code follows the project's style guidelines
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

📚 Documentation preview 📚: https://cala--128.org.readthedocs.build/en/128/

@raymondwjang raymondwjang merged commit 3ed5765 into main Aug 14, 2025
13 checks passed
@raymondwjang raymondwjang deleted the detect-batch branch August 14, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant