Open
Conversation
Equation S.31 states that: phi = LD ./ (K .^ (1-mu)) This would imply: Vout = LD ./ (K.^0.25)
Looking at comegaoptC.m and comegaoptO.m, one understands that tt86rw and tt06, by extension, are indexed as (workplace, residence) matrices. This appears to be the case for tt86rw, since the estimated epsilon is 6.83, consistent with the paper. In camen.m and calcal_adj_TD.m (and all other functions in the repository), the indexing of the travel time matrices changes to (residence, workplace), suggesting that tt06 and ttpub06 are indexed differently from tt86rw. To my knowledge, that implies that either: 1) The indexing in comegaoptC.m is wrong, or 2) The indexing in all functions from the application of camen.m onward are wrong. Since the first option is more probable, I am adding this commit here.
As written, EQQ is not updating across iterations. I believe this should not be the case; thus, I propose changing QT for Q_i in its computing.
The current update rule for theta uses the estimated prices of commercial buildings rather than the guessed prices. Although this substantially improves the convergence rate, it is unusual because theta is then the only endogenous variable defined differently from the others. I therefore propose updating theta using its guessed value instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently implementing this model in Julia and have found what appear to be typos in this MATLAB implementation. In this patch, I state them.