language-server: avoid noisy errors for expected git check-ignore exits#237
Merged
AhmmedSamier merged 1 commit intomasterfrom Feb 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
git check-ignorecan exit with code1to indicate "no matches", but the indexer treated any non-zero exit as an error which produced noisyconsole.erroroutput during incremental/batch indexing and benchmarks.Description
console.errorforgit check-ignorewhen the exit code is1while preserving error logs for other failures inWorkspaceIndexer.processGitCheckBatch(language-server/src/core/workspace-indexer.ts).WorkspaceIndexer.getGitExitCodeto reliably extract a git exit code from both structured error objects and error messages.git check-ignorereturns no matches.Testing
cd language-server && bun test src/core/workspace-indexer.test.ts, and all tests passed (9 pass, 0 fail).cd language-server && bun run benchmarks/incremental.bench.ts, which completed and showed expected timings while reducing noisycheck-ignoreerror messages for exit code1(bench output recorded).check-ignorehandling and does not alter how checks resolve during indexing.Codex Task