Serialize LSP stop, clean up Git listeners, and miscellaneous robustness fixes#241
Merged
AhmmedSamier merged 1 commit intomasterfrom Mar 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DeepLensLspClient.stop()with a newstopPromiseand ensure it waits for any pending start to complete, disposes tracked disposables, and cleans up event emitters exactly once.stopClientInstance()and adjustwaitForStartCompletion()null checks to avoid start/stop races.GitService, improve HEAD-change logging to show the previous HEAD, and fix debounce logging to reference the previous head correctly.isSymbolInformationArray()and use it inreference-code-lens.ts, simplify the label typing insearch-provider.ts, remove a redundant disposal registration inextension.ts, and extend the benchmark tests with aSearch Request Latencycase.Testing
extension.bench.test.ts) including the newSearch Request Latencybenchmark as an automated test; the tests completed successfully.Codex Task