Integrate UserMedia support for controllers across all platforms#107
Open
marc-n-dream wants to merge 9 commits intomasterfrom
Open
Integrate UserMedia support for controllers across all platforms#107marc-n-dream wants to merge 9 commits intomasterfrom
marc-n-dream wants to merge 9 commits intomasterfrom
Conversation
Signed-off-by: marc-n-dream <marc@n-dream.com>
r: restructure the event flow to use a distinct flow
r: externalize the decision on hard vs soft fail
r: Move denial handling back into onPostMessage_ control flow
- Updated format to be using event.type again to be consistent and not introduce yet another field describing what the event is - No need for `granted` as the events already make it clear if the mediaPermission was granted or denied - Added constant for `MEDIA_PERMISSION_DENIED` so the game can check against those strings if needed - Fixed incorrect `denial` and `error` destructures, instead using `reason` for when the permission is denied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integrates support for UserMedia in the AirConsole controller to make it available in web controllers as well as the AirConsole iOS / Android controller application.
These act differently depending on who needs to ask the browser or operating systems for the necessary permissions.