Skip to content
This repository was archived by the owner on Feb 12, 2025. It is now read-only.

Fix regression causing tests to not be run in GHA - #222

Merged
Khatskevich merged 3 commits into
mainfrom
kmichel-fix-gha
May 3, 2024
Merged

Fix regression causing tests to not be run in GHA#222
Khatskevich merged 3 commits into
mainfrom
kmichel-fix-gha

Conversation

@kmichel-aiven

@kmichel-aiven kmichel-aiven commented May 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Extracted from #219

Fixing the bug that disabled tests covered a few issues with them:

  • flake8 was failing, this is covered by the "improve linting" commit.
  • pylint was failing on f39/py3.12 deps, because pylint was still pinned to an old f38 version, bumping for both test runs it is not ideal, but Use different dev dependencies for different fedora versions #219 will provide a proper solution for that issue. Until then, it's better to run tests and have a more modern pylint than what f38 offers than not run tests at all.

nicois and others added 3 commits May 2, 2024 09:06
@kmichel-aiven
kmichel-aiven marked this pull request as ready for review May 2, 2024 07:24
@kmichel-aiven
kmichel-aiven requested a review from a team May 2, 2024 07:24
@Khatskevich
Khatskevich merged commit e283624 into main May 3, 2024
@Khatskevich
Khatskevich deleted the kmichel-fix-gha branch May 3, 2024 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@Khatskevich Khatskevich Khatskevich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kmichel-aiven @Khatskevich @nicois