Add the ability to disable critical css for users who wants to keep css separated#48
Merged
Conversation
…S in a separated file
…-renderer bundles
|
+1 We really need this... |
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the server bundle, the plugin actually disables the CSS extractor and inject every stylesheet directly in the HTML file.
My HTML file did grow up a lot just because of this. I personally use different techniques for a faster CSS load. So sometimes it would be nice to have some flexibility regarding the critical CSS feature.
In this commit, I have added an option called "criticalCss" that can be set in the vue config file in order to disable this feature when we want to keep the CSS extracted in a separated file.