Skip to content

fix(apk-ux): modernize VoyageSetupForm buttons with brokered haptic feedback#1220

Merged
github-actions[bot] merged 1 commit into
Nightlyfrom
nightly/stage-12-apk-ux-262091-2368134061969364774
Jul 25, 2026
Merged

fix(apk-ux): modernize VoyageSetupForm buttons with brokered haptic feedback#1220
github-actions[bot] merged 1 commit into
Nightlyfrom
nightly/stage-12-apk-ux-262091-2368134061969364774

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Generated by: .github/nightly-prompts/12-apk-ux.md

Reasoning:

[UX Issue]: Manual, programmatic haptics.tap() calls inside the useVoyageForm composable bypassed the project's standard declarative v-tactile haptic feedback brokering directive.
[Impact]: Programmatic haptic calls can lead to double-triggering when mixed with elements that use v-tactile or lack direct UI event context propagation in WebView environments.

Changes:

  • [Component/File]: Applied the declarative v-tactile haptic feedback brokering directive on #voyage-set-end-btn, #voyage-activate-btn, and #voyage-cancel-btn in VoyageSetupForm.vue.
  • [Component/File]: Removed manual, redundant haptics.tap() invocations and useHaptics hook reference from useVoyageForm.ts.

Verification:

  • [Automated]: Full Vitest suite passed cleanly with 1421 passing tests, including explicit VoyageSetupForm.spec.ts and useVoyageForm.spec.ts validations.
  • [Architectural]: Dependency cruiser verified zero boundary/layer violations across the monorepo.
  • [Build]: Production client build pnpm run build compiled successfully without error.

Log Updates:

  • Updated .github/nightly-logs/12-apk-ux-coverage.log
  • Updated .github/nightly-logs/00-pr-history.md
  • Updated .github/nightly-logs/00-pipeline-intelligence.md

PR created automatically by Jules for task 2368134061969364774 started by @AlbiDR

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@supabase

supabase Bot commented Jul 25, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project hucktamloykszinwbtuh because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions
github-actions Bot merged commit 51bfa54 into Nightly Jul 25, 2026
3 checks passed
@github-actions
github-actions Bot deleted the nightly/stage-12-apk-ux-262091-2368134061969364774 branch July 25, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants