Skip to content

Re-enable macos x64 builds#288

Merged
RyeMutt merged 2 commits into
developfrom
fix/mac-x64-build
Jun 1, 2026
Merged

Re-enable macos x64 builds#288
RyeMutt merged 2 commits into
developfrom
fix/mac-x64-build

Conversation

@RyeMutt
Copy link
Copy Markdown
Member

@RyeMutt RyeMutt commented Jun 1, 2026

Description

Enable macOS x86_64 builds again.

Related Issues

  • Please link to a relevant GitHub issue for additional context.
    • Bug Fix: Link to an issue that includes reproduction steps and testing guidance.
    • Feature/Enhancement: Link to an issue with a write-up, rationale, and requirements.

Issue Link:


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Enabled additional macOS architecture combinations in the CI build matrix to expand automated build coverage.
    • Added pre-build cleanup steps to the CI workflow to remove temporary files, containers and caches before running builds.

Walkthrough

The CI build workflow now runs the previously excluded macos-26 + arch: x64 matrix combination, and the build job includes a disk-cleanup step that reports disk usage, prunes Docker artifacts, and removes selected tool/cache directories before proceeding.

Changes

CI Configuration

Layer / File(s) Summary
Build matrix exclusion adjustment
.github/workflows/build.yaml
Removed the macos-26 + arch: x64 exclusion entry from the build job's strategy.matrix.exclude, allowing that combination to run in CI.
Build disk-cleanup step
.github/workflows/build.yaml
Added a disk-cleanup block that runs df -h, prunes Docker containers/images, and deletes /usr/local/lib/android, /opt/ghc, and /usr/local/.ghcup to free space during the build.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 In CI fields the matrix grew,
macOS x64 hopped through,
Runners cleared space with a nimble sweep,
Docker pruned, caches sent to sleep,
Builds bounce onward—bright and new.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; it lacks issue links, has unchecked checklist items, and omits important context about disk cleanup changes. Add the related GitHub issue link, provide testing details about the disk cleanup and build changes, and clarify why x64 builds were previously disabled.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: re-enabling macOS x64 builds by removing the exclusion from the CI matrix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build.yaml:
- Around line 224-230: Update the commit message to describe both changes
introduced in this PR: re-enabling macOS x64 builds by removing the matrix
exclusion (the change touching the macos-26 + x64 matrix entry) and the added
Linux disk cleanup steps (the df, sudo docker container/image prune, and sudo rm
-rf lines that remove /usr/local/lib/android, /opt/ghc, and /usr/local/.ghcup).
Use a concise title like "Re-enable macOS x64 builds and free disk space on
Linux runners" and a short body listing the two bullets so both intentions are
clear in git history.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2b6acb05-c0f8-496e-984e-8eb3f285bdf9

📥 Commits

Reviewing files that changed from the base of the PR and between bd07f02 and 74ca40e.

📒 Files selected for processing (1)
  • .github/workflows/build.yaml

Comment thread .github/workflows/build.yaml
@RyeMutt RyeMutt merged commit 477fb7a into develop Jun 1, 2026
17 checks passed
@RyeMutt RyeMutt deleted the fix/mac-x64-build branch June 1, 2026 17:42
@RyeMutt RyeMutt added this to the NEXT milestone Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant