Add support for Act1 Ancients. - #351
Open
JohnnyBazooka89 wants to merge 1 commit into
Open
Conversation
LinnielDW
reviewed
Jul 18, 2026
JohnnyBazooka89
force-pushed
the
feature/add_support_for_act1_ancients
branch
2 times, most recently
from
July 21, 2026 20:31
df45cf6 to
03e4031
Compare
Author
|
I noticed a problem that Ancients added to Act 1 are breaking the custom/daily runs. In Custom & Daily runs there are either no bonuses, or some specialized bonuses defined by modifiers. I think we will have to add an additional check and only add the Ancients if the run is without any modifiers. |
JohnnyBazooka89
marked this pull request as draft
July 26, 2026 15:30
JohnnyBazooka89
force-pushed
the
feature/add_support_for_act1_ancients
branch
from
July 26, 2026 16:30
03e4031 to
da5e60e
Compare
Author
|
I just added another patch, for ensuring that Neow is used in Daily/Custom runs. Unfortunately the patch couldn't be applied next to the adding of the Act 1 Ancients, because we don't have the access to Run State or Owner there. |
JohnnyBazooka89
marked this pull request as ready for review
July 26, 2026 16:31
JohnnyBazooka89
force-pushed
the
feature/add_support_for_act1_ancients
branch
from
July 28, 2026 17:10
da5e60e to
fd7c161
Compare
JohnnyBazooka89
force-pushed
the
feature/add_support_for_act1_ancients
branch
from
July 28, 2026 17:15
fd7c161 to
19c413e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Act1 Ancients.
Unfortunately, it required two patches (including 1 Transpiler). Not gonna lie, these patches were vibe-coded. But they are very simple and they should work fine.
I tested this code locally, and my Ancient spawns correctly in Act1.
In you have any questions, you know how to reach me :)