Add potion image fallback and related code to character template ! :3 - #22
Open
CorynBunnydeer wants to merge 1 commit into
Open
Add potion image fallback and related code to character template ! :3#22CorynBunnydeer wants to merge 1 commit into
CorynBunnydeer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Alchyr from osu!Taiko ! ✿òωó)ง
((You have no idea the surprise I got when I was looking into StS2 modding and saw you created BaseLib, hahah!))
So !
Adding Potion image fallback thingie to the template ! Tried keeping the structure of the rest of the StringExtension helpers.
Basically,
CharModPotionnow looks for:images/potions/<potion-id>.pngand uses this as fallback:images/potions/potion.pngI did it first in my own Character Mod as a means of testing, which used the template as a base. Intentionally did the change just on Character template, given the Content one doesn't have a Potion Pool, as far as I understood (which makes sense), so yeah !
I took a look at precedents, and found #13 , which was implemented separately upstream, so I believed this could be useful.
((Now, do I get kudosu ? ehe :3
Ty for your work on BaseLib ! It's been making this whole effort a lot easier))