Review Juan Bautista#3
Open
jsbautista wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
El código es legible tanto en el html como en el css. Se encontró que no había definido el idioma, por lo que podría generar problemas de accesibilidad. Sus secciones son diferenciables a excepción del main, pues no tenia. Los colores de la pagina me parecen adecuados, aunque la pagina en un dispositivo pequeño tiene muchas diferencias en tamaño de fuente y algunas partes se ven muy pequeñas. La navegación es sencilla e intuitiva, me agrado. en la tabla de "information personal" pudo utilizar el atributo colspan="2" en el th de "personal information". Muy buen trabajo.
Adjunto pantallazo validator.w3.org: