Skip to content

Add ability about loading libraries.json to this library#50

Closed
SNWCreations wants to merge 1 commit intoAlessioDP:masterfrom
SNWCreations:feat/libraries-json-loader
Closed

Add ability about loading libraries.json to this library#50
SNWCreations wants to merge 1 commit intoAlessioDP:masterfrom
SNWCreations:feat/libraries-json-loader

Conversation

@SNWCreations
Copy link

See Minecrell/plugin-yml#54

Really useful when working with that Gradle plugin.

@frengor
Copy link
Collaborator

frengor commented Jul 27, 2024

We already have such functionality in the gradle branch:

public void configureFromJSON() {

Example of JSON configuration

@SNWCreations
Copy link
Author

SNWCreations commented Jul 27, 2024

We already have such functionality in the gradle branch:

public void configureFromJSON() {

Example of JSON configuration

Sorry for lossing the research on this and thank you for your reply. IDK how to let plugin-yml generate such json. :/ Any ideas?
Will the base branch of this PR still supported after v2 release? I'm focus on the stability.

@frengor
Copy link
Collaborator

frengor commented Jul 27, 2024

IDK how to let plugin-yml generate such json. :/ Any ideas?

I would make a PR to Minecrell/plugin-yml and make it generate a Libby compatible JSON. Another option is to read the Minecrell/plugin-yml's JSON manually and load the libraries using Libby.

Will the base branch of this PR still supported after v2 release? I'm focus on the stability.

No, only the 2.x.x will be supported, since it will become the stable version.

@frengor frengor closed this Jul 27, 2024
@SNWCreations
Copy link
Author

SNWCreations commented Jul 28, 2024

IDK how to let plugin-yml generate such json. :/ Any ideas?

I would make a PR to Minecrell/plugin-yml and make it generate a Libby compatible JSON. Another option is to read the Minecrell/plugin-yml's JSON manually and load the libraries using Libby.

Will the base branch of this PR still supported after v2 release? I'm focus on the stability.

No, only the 2.x.x will be supported, since it will become the stable version.

Okay. Thanks for your reply. Looking forward to the v2 release.

Addition: Minecrell projects rarely updates, IDK if making PR to it is a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants