Open
Conversation
Users can now move through inserted text using the arrow keys. Adding text to inserted texts invalidates the inserted text, and pressing backspace inside an inserted text deletes it altogether. Pre-existing inserted texts must now be initialized with a `data-atwho-chosen-value` attribute whose value must equal the contents of the inserted text (this should be later automated).
Delete and backspace keys now trigger more general change detection that works for both keys.
Owner
Author
|
This fixes #4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete key now works. Both the backspace and delete keys now take a higher priority, triggering a content disparity check each time they are pressed. The changes in #5 were required for the fix, and so they are included in this PR.