Skip to content

Update rubocop-rails 2.24.1 → 2.29.1 (minor)#701

Closed
depfu[bot] wants to merge 1 commit intomasterfrom
depfu/update/rubocop-rails-2.29.1
Closed

Update rubocop-rails 2.24.1 → 2.29.1 (minor)#701
depfu[bot] wants to merge 1 commit intomasterfrom
depfu/update/rubocop-rails-2.29.1

Conversation

@depfu
Copy link
Copy Markdown
Contributor

@depfu depfu bot commented Jan 26, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.24.1 → 2.29.1) · Repo · Changelog

Release Notes

2.29.1

Bug fixes

  • #1423: Fix an error for Rails/StrongParametersExpect when using permit with no arguments. (@koic)
  • #1417: Fix an incorrect autocorrect for Rails/StrongParametersExpect when using a leading dot multiline call to require with permit. (@koic)
  • #1356: Enhance Rails/DuplicateAssociation to handle alias. (@ydakuka)
  • #1389: Handle TypeError caused by passing array literals as arguments to File methods in Rails/FilePath cop. (@ydakuka)
  • #1389: Handle TypeError caused by passing array literals as arguments to File methods in Rails/RootPathnameMethods cop. (@ydakuka)
  • #1228: Enhance Rails/SaveBang to properly handle instance variables. (@ydakuka)

2.29.0

New features

  • #1407: Add new Rails/MultipleRoutePaths cop. (@koic)
  • #1358: Add new Rails/StrongParametersExpect cop. (@koic)

Bug fixes

  • #1409: Fix an error for Rails/ReversibleMigration when calling drop_table without any arguments. (@earlopain)
  • #1397: Fix an incorrect autocorrect for Rails/TimeZone when Time.new has a string argument. (@mterada1228)
  • #1406: Fix autocorrection for Rails/IndexBy and Rails/IndexWith when map { ... }.to_h is enclosed in another block. (@franzliedke, @eugeneius)
  • #1404: Update Rails/IndexBy and Rails/IndexWith to support numbered block parameters. (@eugeneius)
  • #1405: Fix autocorrection for Rails/IndexWith when the value is a hash literal without braces. (@koic, @eugeneius)
  • #1414: Fix Rails/HttpPositionalArguments cop false positives with arguments forwarding. (@viralpraxis)

Changes

  • #1410: Make registered cops aware of AllCops: MigratedSchemaVersion. (@koic)

2.28.0

New features

  • #1383: Introduce AllCops: MigratedSchemaVersion config. (@koic)

Bug fixes

  • #1390: Fix an incorrect autocorrect for Rails/SelectMap when select has no receiver and method chains are used. (@masato-bkn)
  • #1382: Fix false negatives for Rails/RedundantActiveRecordAllMethod when using all method in block. (@masato-bkn)
  • #1397: Fix Rails/FilePath cop error on join method with implicit receiver. (@viralpraxis)
  • #1398: Fix Rails/FilePath cop error in case of extra operations in Rails.root interpolation. (@viralpraxis)
  • #1392: Fix Rails/FilePath cop error with rescued Rails.root. (@viralpraxis)

Changes

  • #1388: Modify Rails/Pluck to ignore map/collect when used inside blocks to prevent potential N+1 queries. (@masato-bkn)

2.27.0

Bug fixes

  • #1377: Fix an error for Rails/EnumSyntax when positional arguments are used and options are not passed as keyword arguments. (@koic)
  • #1367: Fix Rails/TimeZone should not report offense on String#to_time with timezone specifier. (@armandmgt)

Changes

  • #727: Disable Rails/TransactionExitStatement on Rails >= 7.2. (@earlopain)
  • #1374: Change Rails/EnvLocal to handle negated conditions. (@fatkodima)
  • #1195: Change Rails/SelectMap to handle safe navigation operators. (@fatkodima)

2.26.2

Bug fixes

  • #1362: Fix false positives for Rails/EnumSyntax when using Ruby 2.7. (@koic)
  • #1269: Fix false positives for Rails/ActionControllerFlashBeforeRender in combination with implicit returns. (@earlopain)
  • #1326: Fix wrong autocorrect for Rails/FilePath when passing an array to File.join. (@earlopain)

Changes

2.26.1

Bug fixes

  • #1343: Fix false negatives for Rails/EnumSyntax for non-literal mappings. (@earlopain)
  • #1340: Fix a false positive for Rails/WhereEquals, Rails/WhereNot, and Rails/WhereRange when qualifying the database name. (@earlopain)

Changes

  • #1342: Change Rails/ApplicationRecord to ignore migrations. (@fatkodima)
  • #1350: Change Rails/EnumSyntax to autocorrect underscored options. (@fatkodima)

2.26.0

New features

Bug fixes

  • #1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. (@earlopain)
  • #1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. (@earlopain)
  • #1337: Fix an error for Rails/Validation when passing no arguments. (@earlopain)
  • #1330: Fix an error for Rails/WhereNot when using placeholder without second argument. (@earlopain)
  • #1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. (@tldn0718)
  • #1313: Fix false positives for Rails/CompactBlank when using collection.reject!. (@koic)
  • #1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. (@earlopain)
  • #1306: Make Rails/PluralizationGrammar aware of byte methods. (@earlopain)
  • #1302: Allow params receiver by default for Style/CollectionMethods. (@koic)
  • #1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). (@earlopain)

Changes

  • #1308: Change Rails/CompactBlank to handle select(&:present?). (@fatkodima)
  • #1303: Change Rails/IgnoredSkipActionFilterOption to handle multiple callbacks. (@fatkodima)
  • #1199: Make Rails/WhereEquals aware of where.not(...). (@earlopain)
  • #1003: Change Rails/RootPathnameMethods to detect offenses on Dir.[]. (@r7kamura)

2.25.1

Bug fixes

  • #1280: Look for change_column_null for Rails/BulkChangeTable. (@ccutrer)
  • #1299: Fix an error for Rails/NotNullColumn when the block for change_table is empty. (@earlopain)
  • #1281: Fix Rails/WhereRange autocorrect for complex expressions. (@fatkodima)
  • #1282: Fix Rails/WhereRange to correctly handle template strings with extra spaces. (@fatkodima)

Changes

  • #1295: Cover validates_comparison_of in Rails/Validation. (@ChaelCodes)
  • #1288: Let Rails/LinkToBlank look into link_to_if and link_to_unless, too. (@fwolfst)
  • #1286: Mark Rails/SkipsModelValidations as unsafe. (@koic)
  • #1283: Mark Rails/WhereRange as unsafe autocorrect. (@fatkodima)

2.25.0

New features

Bug fixes

  • #1270: Fix an incorrect autocorrect for Rails/Validation when using validates_size_of. (@koic)
  • #1278: Fix a false positive for Rails/SkipsModelValidations when using insert or insert! with a safe navigator. (@tldn0718)
  • #1260: Fix a performance regression caused by Rails/UnknownEnv when using Rails 7.1. (@lukasfroehlich1)

Changes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
Go to the Depfu Dashboard to see the state of your dependencies and to customize how Depfu works.

@depfu
Copy link
Copy Markdown
Contributor Author

depfu bot commented May 18, 2025

Closed in favor of #800.

@depfu depfu bot closed this May 18, 2025
@depfu depfu bot deleted the depfu/update/rubocop-rails-2.29.1 branch May 18, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants