Refactor to proper package, embed Drission#1
Open
ppfeister wants to merge 18 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any thoughts on this embed? We can loop @ ilike2burnthing in for a look if so, before making any merges
Embedding Drission and it's two related dependencies would prevent countless downstream issues, and the refactor to a properly installable package would help it become a properly installable dependency for other projects.
Both the Dockerfile and PyProject seem to work for the most part. Docker images may have an inconsistent bug with the browser --- similar to the one you noticed before, maybe?
Not sure if that relates to your original Dockerfile changes, but if they do then I can bring in that fix
With this change,
pip install FlareSolverr==0.0.1b1is also a functional method, as either a dependency for downstream containers or, pending zombie chromium patch, as a standalone.(referencing FlareSolverr#1300 (comment))