Skip to content

1.21.1 Fix issue with skybox and caramel cube hitboxes #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnukWarrior wants to merge 2 commits into
base: 1.21.1
Choose a base branch
from
Open

1.21.1 Fix issue with skybox and caramel cube hitboxes #1749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b05a28
Fix skybox moving with the camera incorrectly
AnukWarrior Jul 11, 2026
abf0219
Fix all caramel cube sizes having same hitbox
AnukWarrior Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/com/github/alexmodguy/alexscaves/mixin/client/LevelRendererMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ private void ac_renderSky(Matrix4f frustumMatrix, Matrix4f projectionMatrix, flo

// In 1.21, we need to create our own PoseStack since it's no longer passed
PoseStack poseStack = new PoseStack();
// Added mulPose to fix the skybox moving with the camera incorrectly
poseStack.mulPose(frustumMatrix);

runnable.run();
if (!foggy) {
Expand Down
6 changes: 2 additions & 4 deletions src/main/java/com/github/alexmodguy/alexscaves/server/entity/living/CaramelCubeEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,10 +283,8 @@ public void onSyncedDataUpdated(EntityDataAccessor<?> dataAccessor) {
super.onSyncedDataUpdated(dataAccessor);
}

// 1.21: getDimensions(Pose) is now final in LivingEntity and cannot be overridden.
// Dimensions are now handled via EntityType.Builder.dimensions() or getDefaultDimensions().
// This method is kept for reference but renamed to avoid compilation errors.
private EntityDimensions getCustomDimensions(Pose pose) {
@Override
public EntityDimensions getDefaultDimensions(Pose poseIn) {
switch (this.getSlimeSize()) {
case 2:
return LARGE_DIMENSIONS;
Expand Down