Skip to content

Fix books not dimming the world behind them #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
digi2303 wants to merge 2 commits into
base: 1.21
Choose a base branch
from
+3 −7
Open

Fix books not dimming the world behind them #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5d0991
Fix books not dimming the world behind them
digi2303 Aug 5, 2026
cd8f494
Draw the book background once, behind the book
digi2303 Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/main/java/com/github/alexthe666/citadel/client/gui/GuiBasicBook.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,13 +272,8 @@ protected void renderBlurredBackground(float partialTick) {
// Do nothing - this prevents the blur effect from being applied
}

/**
* Override to disable the menu background that was added in Minecraft 1.21
* Without this override, the book appears darker due to the overlay
*/
@Override
protected void renderMenuBackground(GuiGraphics guiGraphics) {
// Do nothing - this prevents the dark menu background from being rendered
public void renderBackground(GuiGraphics guiGraphics, int x, int y, float partialTicks) {
}

@Override
Expand All @@ -289,7 +284,8 @@ public void render(GuiGraphics guiGraphics, int x, int y, float partialTicks) {
int bindingR = bindingColor >> 16 & 255;
int bindingG = bindingColor >> 8 & 255;
int bindingB = bindingColor & 255;
this.renderBackground(guiGraphics, x, y, partialTicks);
this.renderTransparentBackground(guiGraphics);
guiGraphics.flush();
int k = (this.width - this.xSize) / 2;
int l = (this.height - this.ySize + 128) / 2;
BookBlit.blitWithColor(guiGraphics, getBookBindingTexture(), k, l, 0, 0, xSize, ySize, xSize, ySize, bindingR, bindingG, bindingB, 255);
Expand Down