Skip to content

Allow disable of native bookmarks #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v12mike wants to merge 3 commits into
base: phpBB3.2
Choose a base branch
from
Open

Allow disable of native bookmarks #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb0613c
Update ucp_postbookmark_body.html
AlexSheer Oct 1, 2017
3db6a47
Merge pull request #1 from AlexSheer/master
v12mike Jul 27, 2018
8233467
Allow this extension to provide post bookmark feature while havnt nat…
Jul 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions event/listener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function load_language_on_setup($event)

public function get_topic_data($event)
{
if ($this->user->data['is_registered'] && $this->config['allow_bookmarks'])
if ($this->user->data['is_registered']&& !$this->user->data['is_bot'])
{
$topic_data = $event['topic_data'];
$posts_bookmark = array();
Expand All @@ -118,7 +118,7 @@ public function get_topic_data($event)

public function modify_post_row($event)
{
if ($this->user->data['is_registered'] && $this->config['allow_bookmarks'])
if ($this->user->data['is_registered'] && !$this->user->data['is_bot'])
{
$row = $event['row'];
$post_row = $event['post_row'];
Expand Down
25 changes: 13 additions & 12 deletions styles/prosilver/template/ucp_postbookmark_body.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,17 @@ <h2>{L_UCP_POSTBOOKMARK}</h2>
<!-- IF S_NO_DISPLAY_BOOKMARKS -->
<p class="error">{L_BOOKMARKS_DISABLED}</p>
<!-- ELSE -->

<!-- IF .postrow -->
<ul class="topiclist">
<ul class="topiclist missing-column">
<li class="header">
<dl class="icon">
<dt>{L_BOOKMARKS}</dt>
<dd class="lastpost"><span>{L_COMMENT}</span></dd>
<dl>
<dt><div class="list-inner">{L_BOOKMARKS}</div></dt>
<dd class="info"><span>{L_COMMENT}</span></dd>
<dd class="mark">{L_MARK}</dd>
</dl>
</li>
</ul>
<ul class="topiclist cplist">
<ul class="topiclist cplist missing-column">

<!-- BEGIN postrow -->
<li class="row<!-- IF postrow.S_POST_REPORTED --> reported<!-- ELSEIF postrow.S_ROW_COUNT is odd --> bg1<!-- ELSE --> bg2<!-- ENDIF -->">
Expand All @@ -34,14 +33,16 @@ <h2>{L_UCP_POSTBOOKMARK}</h2>
<!-- ELSE -->
<dl>
<dt>
<div class="list-inner with-mark">
<a href="{postrow.U_VIEW_POST}" class="topictitle">{postrow.POST_TITLE}</a><br />
{L_POST_BY_AUTHOR} {postrow.TOPIC_AUTHOR} &raquo; {postrow.POST_TIME}
<div class="list-inner">
<a class="topictitle" href="{postrow.U_VIEW_POST}">{postrow.POST_TITLE}</a><br />
{L_POST_BY_AUTHOR}{L_COLON} {postrow.TOPIC_AUTHOR} &raquo; {postrow.POST_TIME}
<div class="responsive-show" style="display: none;">
{L_COMMENT}{L_COLON} {postrow.BOOKMARK_DESC}<br />
{L_ADDED}{L_COLON} {postrow.BOOKMARK_TIME}
</div>
</div>
</dt>
<dd class="lastpost"><span><dfn>{L_LAST_POST} </dfn> {postrow.BOOKMARK_DESC}
<br />{L_ADDED}&raquo; {postrow.BOOKMARK_TIME}</span>
</dd>
<dd class="info"><span>{L_COMMENT}{L_COLON} {postrow.BOOKMARK_DESC}<br />{L_ADDED}{L_COLON} {postrow.BOOKMARK_TIME}</span></dd>
<dd class="mark"><input type="checkbox" name="t[{postrow.POST_ID}]" id="t{postrow.POST_ID}" /></dd>
</dl>
<!-- ENDIF -->
Expand Down