Skip to content

refactor: replace if-chain in RunningDecimationFilter._dec_func with dict lookup #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maayanmatsliah-tech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: replace if-chain in RunningDecimationFilter._dec_func with dict lookup #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions pylablib/core/dataproc/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,8 @@ class RunningDecimationFilter:
on_incomplete: determines what to return while the filter window is not yet full;
can be ``"none"`` (default, return ``None``), or ``"partial"`` (operate on the partial accumulated data)
"""
_MODE_FUNCS = {"mean": np.mean, "min": np.min, "max": np.max, "median": np.median}

def __init__(self, n, mode="mean", on_incomplete="none"):
self.n=n
funcargparse.check_parameter_range(mode,"mode",["mean","min","max","median"])
Expand All @@ -559,14 +561,9 @@ def __init__(self, n, mode="mean", on_incomplete="none"):
funcargparse.check_parameter_range(on_incomplete,"on_incomplete",["none","partial"])
self.on_incomplete=on_incomplete
def _dec_func(self):
if self.mode=="mean":
return np.mean
if self.mode=="min":
return np.min
if self.mode=="max":
return np.max
if self.mode=="median":
return np.median
"""Return the numpy function corresponding to the current decimation mode."""
return self._MODE_FUNCS[self.mode]

def get(self):
"""Get the filtered result"""
if len(self._buffer)<self.n and self.on_incomplete=="none":
Expand Down