Fix interval cleanup in typewriter text#1
Open
AlexandreGaubert wants to merge 1 commit into
Hidden character warning
The head ref may contain hidden characters: "codex/g\u00e9rer-setinterval-avec-useref-et-useeffect"
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes how the interval is managed in the typewriter text component by storing the interval ID in a ref and properly clearing it on component unmount.
- Removed the useCallback hook and now using a plain function for creating the interval.
- Introduced an intervalRef to store the interval ID and added a cleanup function in useEffect.
Comments suppressed due to low confidence (1)
src/components/reusable/TypewritterText/TypewritterText.tsx:9
- The component function is named 'TypewriterText' but the file and directory use 'TypewritterText'. Consider renaming either the component or the file/directory to maintain a consistent naming convention.
export default function TypewriterText({ texts, color }: Props) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useRefTesting
yarn test --watchAll=false(fails: package not present in lockfile)https://chatgpt.com/codex/tasks/task_e_6840855a068c832397b6ed2bd3512d4d