Skip to content

Update GHA and precommit#338

Merged
jashapiro merged 7 commits intomainfrom
jashapiro/action-update
Apr 8, 2026
Merged

Update GHA and precommit#338
jashapiro merged 7 commits intomainfrom
jashapiro/action-update

Conversation

@jashapiro
Copy link
Copy Markdown
Member

Originally done to close https://github.com/AlexsLemonade/ScPCA-admin/issues/1329, but pre-commit was failing because of renv updates/bugs, so I started to try to move off it.

Didn't get rid of everything, but did make some changes that may be nice.
Switching to typos and air for formatting and spelling, respectively.
I made all the spelling fixes that typos found, but did not update formatting with air except in the modified files. Other formatting changes will come as files are modified.

I was thinking I might be adding pre-commit.ci to this repo, but this will hold off until the renv fixes are available.

@jashapiro jashapiro requested a review from sjspielman April 8, 2026 15:53
Copy link
Copy Markdown
Member

@sjspielman sjspielman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking I might be adding pre-commit.ci to this repo, but this will hold off until the renv fixes are available.

I would support adding this but certainly seems reasonable to circle back.

- id: typos
- repo: https://github.com/lorenzwalthert/precommit
rev: v0.4.3
rev: v0.4.3.9021
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I badly want to suggest this, but I won't actually for obvious reasons. But clearly this should be...

rev: v0.4.3.90210

@jashapiro jashapiro merged commit eaab6b6 into main Apr 8, 2026
11 checks passed
@jashapiro jashapiro deleted the jashapiro/action-update branch April 8, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants