Conversation
sjspielman
approved these changes
Apr 8, 2026
Member
sjspielman
left a comment
There was a problem hiding this comment.
I was thinking I might be adding pre-commit.ci to this repo, but this will hold off until the renv fixes are available.
I would support adding this but certainly seems reasonable to circle back.
| - id: typos | ||
| - repo: https://github.com/lorenzwalthert/precommit | ||
| rev: v0.4.3 | ||
| rev: v0.4.3.9021 |
Member
There was a problem hiding this comment.
I badly want to suggest this, but I won't actually for obvious reasons. But clearly this should be...
rev: v0.4.3.90210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally done to close https://github.com/AlexsLemonade/ScPCA-admin/issues/1329, but pre-commit was failing because of renv updates/bugs, so I started to try to move off it.
Didn't get rid of everything, but did make some changes that may be nice.
Switching to
typosandairfor formatting and spelling, respectively.I made all the spelling fixes that
typosfound, but did not update formatting withairexcept in the modified files. Other formatting changes will come as files are modified.I was thinking I might be adding pre-commit.ci to this repo, but this will hold off until the
renvfixes are available.