Skip to content

Add remaining text to spatial 01 notebook#957

Merged
sjspielman merged 7 commits intomasterfrom
sjspielman/946-947-remaining-text
Mar 24, 2026
Merged

Add remaining text to spatial 01 notebook#957
sjspielman merged 7 commits intomasterfrom
sjspielman/946-947-remaining-text

Conversation

@sjspielman
Copy link
Copy Markdown
Member

Closes #946 (woopsies branch name; this is already closed)
Closes #947
Closes #948

This PR wraps up the text for our first notebook! Changes include:

  • normalization section. any other details you can think of to point out here? I kept it short and sweet
  • plot section. not too many changes needed here. I did include a caveat that none of us is a histologist. I did not include the caveat that Claude helped me interpret this H&E (Claude said a lot more things, but I didn't want to include most of it because I can't really evaluate how accurate Claude was! So, I kept the interpretation pretty basic).
  • I also cleaned up spacing overall and made sure we always have a new line before/after chunks, and added a more prominent "hey we think you should read OSTA" link (pretty much copied that from one of our single-cell notebooks and swapped in osta for osca).

@sjspielman sjspielman requested a review from allyhawkins March 23, 2026 18:47
Copy link
Copy Markdown
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment about normalization. I agree that we should be upfront about the caveats you mention, but I do think we are going to get a lot of questions. I don't know that we really know the answer to them though.

It's worth noting this approach doesn't take spatial information directly into account; there are some approaches out there which account for spatial information, but this aspect of analysis seems to be pretty in flux.
Also, bear in mind the caveat that in some cases library size itself is [also confounded with spatial structure](https://link.springer.com/article/10.1186/s13059-024-03241-7); so, keep your eyes peeled for normalization developments, since this space is evolving rapidly.
It's important to note that this approach doesn't take spatial information directly into account, although there are [some proposed methods](https://bioconductor.org/books/3.22/OSTA/pages/seq-intermediate-processing.html#spatially-aware-normalization) which do.
It's just as important to note that the normalization approach we're using here could also be problematic, as there's some evidence that library size itself [can be confounded with spatial structure](https://link.springer.com/article/10.1186/s13059-024-03241-7).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to be transparent about this, but we are going to get a lot of questions about why we are normalizing if this is the case, so we should be prepared to answer those...

sjspielman and others added 2 commits March 23, 2026 17:17
Co-authored-by: Ally Hawkins <54039191+allyhawkins@users.noreply.github.com>
@sjspielman sjspielman merged commit 6d8e92c into master Mar 24, 2026
5 checks passed
@sjspielman sjspielman deleted the sjspielman/946-947-remaining-text branch March 24, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants