fix: trigger the real macOS Screen Recording prompt instead of bouncing to Settings - #12
Merged
Merged
Conversation
…g up macOS has no API to programmatically request Screen Recording access (unlike camera/microphone's askForMediaAccess) - the only thing that ever shows the real system permission dialog is an actual capture-related call. getMediaAccessStatus() is a passive read of already-decided state. startStudioRecording checked that status and, if not granted, jumped straight to opening System Settings - so a user who had never been prompted before had nothing to grant there, and could never actually trigger the real dialog through normal use of the Record button. Verified this directly this session: clicking Record repeatedly opened System Settings with no native dialog ever appearing, for an app that had genuinely never been granted or denied. Now, when permission isn't granted, we call getSources() (which the source selector already needs anyway) to trigger the real prompt first, then re-check. If the user was already explicitly denied before, this just fails silently same as before and we still fall back to Settings.
3 tasks
Alfredoalv13
pushed a commit
that referenced
this pull request
Jul 24, 2026
Same root cause as the Screen Recording fix (#12), for Accessibility: getAccessibilityPermissionStatus() calls isTrustedAccessibilityClient(false), a passive read that never prompts or registers the app in System Settings. requestAccessibilityPermission() (isTrustedAccessibilityClient(true)) already existed in the backend and is exposed to the renderer, but was never called anywhere - startStudioRecording jumped straight to opening System Settings when accessibility wasn't trusted, leaving nothing there to grant on first use. Verified directly this session: after fixing Screen Recording, an otherwise fresh app install kept showing "Accessibility permission is required" even after toggling what appeared to be the correct entry in System Settings and doing a full quit-and-reopen, because that request path was never exercised. Now mirrors the Screen Recording fix: call requestAccessibilityPermission() when not yet trusted, then re-check, before falling back to Settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan