fix: Quit & Reopen could silently quit without ever reopening - #15
Merged
Conversation
This app enforces requestSingleInstanceLock() (main.ts: app.quit() runs immediately if the lock can't be acquired). Verified directly this session that this is what was silently eating the "Quit & Reopen" relaunch: if the new process spawned via `open` starts up while this process still holds the lock, it sees another instance already running and immediately quits itself - so both the old and new process end up exited, and no window ever reappears. PR #13's fix (delay before app.exit()) didn't address this since delaying app.exit() only holds the lock longer, making the race worse rather than avoiding it. Explicitly release the lock before spawning the replacement process, so it can always acquire it regardless of exact timing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan