fix: floating webcam preview gets clipped/stuck in HUD passthrough-fallback mode - #17
Merged
Merged
Conversation
The drag-clamping math used Math.max(window.innerWidth, window.screen.width) (and the height equivalent), on the assumption the HUD overlay window always covers the full screen. It doesn't: getHudOverlayWindowBounds() in electron/hudOverlayBounds.ts only sizes it to the full screen when mouse passthrough is supported. In the non-passthrough fallback mode, the window is deliberately small - a band anchored to the bottom of the screen - so clamping against the physical screen size let the preview compute positions outside what the window can actually render, clipping it at the window's real edge and making it look stuck a fraction of the way up the screen. Clamping against window.innerWidth/innerHeight directly keeps the preview within whatever the window's actual current size is, correct in both modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan