fix: Studio window hides during recording, webcam bubble can use full screen - #21
Merged
Merged
Conversation
…screen Two related UX fixes: - The Studio window stayed in front the moment you clicked Record, forcing you to manually switch away from VybeClip before you could even start capturing anything. showOrCreateRecordingControls() now hides it (not closes - the existing restore-on-return logic in createWindow()/focusOrCreateMainWindow() brings it back unchanged). hud-overlay-close restores it again on cancel, but not when a recording successfully hands off to the editor (checked via getExistingEditorWindow()), so the editor stays the sole window in that case. - The floating webcam preview bubble was stuck at the bottom edge of the screen, only draggable a little side to side. Root cause: the HUD overlay window intentionally shrinks to a compact, non-click-through band during active recording (isHudOverlayCanvasActive), so the stop/pause controls stay reliably clickable without depending on hover-based passthrough toggling - but that band is only tall enough for the HUD bar itself, leaving the bubble nowhere to go; it was being visually clipped at the window's real edge, not merely CSS-clipped. The renderer now tells the main process whenever a webcam preview is actually showing (setHudOverlayWebcamPreviewActive), and the window widens to the full work area in that case. This is deliberately kept separate from isHudOverlayCanvasActive() itself, which also gates the monitor-boundary-crossing drag relocation logic and should stay tied to the platform/passthrough check alone. The existing hover-driven mouse-passthrough toggling (already wired to the bubble's own pointer events) continues to keep clicks passing through everywhere except the HUD bar/bubble, independent of the window's size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan