feat: inline caption editing in the preview - #24
Merged
Conversation
Double-clicking the caption box in the editor preview now enters an editable state: a textarea pre-filled with the visible caption block's text appears in place of the read-only word spans, auto-focused with the text selected. Enter commits (Shift+Enter for a newline), Escape or blur cancels. Playback pauses automatically on entering edit mode so the underlying caption block can't scroll out from under the edit. This wires up updateCaptionCuesForEditedTarget/CaptionEditTarget in captionEditing.ts, which already had full logic and test coverage for redistributing word timing across the edited text (including edits that span multiple cues) but had no UI calling it. Verified live against a packaged build: double-click enters edit mode with the correct pre-filled text, Enter commits and the new text renders immediately, Escape discards the draft and restores the prior text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
captionEditing.ts—updateCaptionCuesForEditedTarget,CaptionEditTarget) to real UI. It had full logic and test coverage but nothing in the app called it.Test plan
npx tsc -p tsconfig.json --noEmit— cleannpx vitest --run— 819/819 passing